From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 02/02] sata_mv: workaround for multi_count errata sata24 Date: Mon, 13 Apr 2009 13:25:28 -0400 Message-ID: <49E37588.10506@pobox.com> References: <49E359D6.1090309@rtr.ca> <49E35A5E.4020204@rtr.ca> <49E35BF8.1070402@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:42001 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbZDMRZc (ORCPT ); Mon, 13 Apr 2009 13:25:32 -0400 In-Reply-To: <49E35BF8.1070402@rtr.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: IDE/ATA development list , Tejun Heo , Alan Cox Mark Lord wrote: > Someday I'll fix that, if you guys don't beat me to it. > I suppose we just need to issue the SET_MULTIPLE command from > the drive revalidation code. IMO this would be a good idea to do, across many ATA devices. IIRC there is at least one other chip that snoops the set-multiple command, and sets internal chip parameters. Thus, like SET FEATURES - XFER MODE, it seems wise to unconditionally issue SET MULTIPLE for ATA devices, under the logic that it more-thoroughly initializes the controller and device, ensuring we are at a known state at all times. Wanna do a patch? :) Although not the greatest code location, I'm guessing ata_dev_read_id() would probably be the place... Ideally we would have a post-IDENTIFY reset sequence function. Jeff