From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
David Haun <drhaun88@gmail.com>,
liw@liw.fi, jmcarranza@gmail.com
Subject: Re: [PATCH UPDATED #upstream-fixes] libata: handle SEMB signature better
Date: Thu, 16 Apr 2009 15:22:43 -0400 [thread overview]
Message-ID: <49E78583.5030401@garzik.org> (raw)
In-Reply-To: <49E4FE46.1010006@kernel.org>
Tejun Heo wrote:
> WDC WD1600JS-62MHB5 successfully hits the window between ATA/ATAPI-7
> and Serial ATA II standards and reports 3c/c3 signature which now is
> assigned to SEMB. Make ata_dev_classify() report ATA_DEV_SEMB on the
> sig and let ata_dev_read_id() work around it by trying IDENTIFY once.
>
> This fixes bko#11579.
>
> UPDATED: Jeff spotted stupid bug caused by lingering debug code.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: David Haun <drhaun88@gmail.com>
> Reported-by: Lars Wirzenius <liw@liw.fi>
> Reported-by: Juan Manuel <jmcarranza@gmail.com>
> ---
> drivers/ata/libata-core.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
applied
prev parent reply other threads:[~2009-04-16 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 10:35 [PATCH #upstream-fixes] libata: handle SEMB signature better Tejun Heo
2009-04-14 12:12 ` Jeff Garzik
2009-04-14 21:03 ` Tejun Heo
2009-04-14 21:08 ` Jeff Garzik
2009-04-14 21:21 ` [PATCH UPDATED " Tejun Heo
2009-04-16 7:37 ` Borislav Petkov
2009-04-16 19:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E78583.5030401@garzik.org \
--to=jeff@garzik.org \
--cc=drhaun88@gmail.com \
--cc=jmcarranza@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=liw@liw.fi \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).