From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Zhenwen Xu <helight.xu@gmail.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] v3 fix error on drivers/ata/pata_legacy.c
Date: Fri, 17 Apr 2009 06:41:45 -0400 [thread overview]
Message-ID: <49E85CE9.4090306@pobox.com> (raw)
In-Reply-To: <20090417112713.04ed51d7@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Fri, 17 Apr 2009 15:32:59 +0800
> Zhenwen Xu <helight.xu@gmail.com> wrote:
>
>> fix those errors:
>>
>> drivers/ata/pata_legacy.c: In function ‘pdc_data_xfer_vlb’:
>> drivers/ata/pata_legacy.c:289: error: ‘ap’ undeclared (first use in this function)
>> drivers/ata/pata_legacy.c:289: error: (Each undeclared identifier is reported only once
>> drivers/ata/pata_legacy.c:289: error: for each function it appears in.)
>> drivers/ata/pata_legacy.c: At top level:
>> drivers/ata/pata_legacy.c:869: error: ‘ATA_PFLAG_PIO32_CHANGE’ undeclared here (not in a
>> +function)
>> make[2]: *** [drivers/ata/pata_legacy.o] Error 1
>> make[1]: *** [drivers/ata] Error 2
>
> Looks good to me. I shall have to find something larger than PROPOSED in
> the patch title to stop Jeff applying things that were discussion code
It had a 'signed-off-by', which I took to mean, it was a proposed patch
that was OK to merge once people were happy... Sorry about that
misinterpretation.
Jeff
prev parent reply other threads:[~2009-04-17 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 7:32 [PATCH] v3 fix error on drivers/ata/pata_legacy.c Zhenwen Xu
2009-04-17 10:27 ` Alan Cox
2009-04-17 10:41 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E85CE9.4090306@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=helight.xu@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).