Re: [PATCH 02/15] ide-tape: remove back-to-back REQUEST_SENSE detection

[Tejun Heo <htejun@gmail.com>]

Hello,

Borislav Petkov wrote:
> Honestly, I don't know. The code predates even the initial git
> commit of the kernel so I guess nobody knows?

Heh.. maybe Mark does.

> And yeah, such a check looks a bit too much so I won't have any
> problem with removing it. Nevertheless, we need the small fix above
> in the ->do_request callback for all other packet commands since
> ide-tape uses currently ide_queue_pc_tail() for sending those. I
> know, I know, it is ugly and we're working on it :).

Can you explain a bit more about the bug?  I'm not really following.

>> Yet another problem is that idetape_flush_tape_buffers() uses pc which
>> is on stack which drive->pc ends up pointing directly to, so it won't
>> work.  Nobody expects that the pointer it passed into an API should be
>> accessible by the API implementation after it was done with it.
>> That's just a silly thing to do.
> 
> The whole on stack passing should be passe :) soon since we're about to kill
> those ide_atapi_pc's.

Hooray.

> As I said before, this is very old code that is really rusty and
> we're trying to janitor it slowly.

Yeap, sure.

Thanks.

-- 
tejun