From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 02/02] sata_mv: workaround for multi_count errata sata24
Date: Fri, 17 Apr 2009 21:11:27 -0400 [thread overview]
Message-ID: <49E928BF.5060402@rtr.ca> (raw)
In-Reply-To: <49E90AD9.7070706@pobox.com>
Jeff Garzik wrote:
> Mark Lord wrote:
>> Workaround for errata SATA#24 in sata_mv.
>> This errata affects WRITE_MULTI* commands when
>> the device multi_count produces a DRQ block size >= 4Kbytes.
>>
>> We work around it here by converting such operations
>> into ordinary PIO_WRITEs instead.
>>
>> Note that this might result in a PIO FUA write unavoidably being
>> converted
>> into a non-FUA write. In practice, any system using FUA is also going
>> to be
>> using DMA rather than PIO, so this shouldn't affect anyone in the real
>> world.
>
> I'm applying this, but I think a follow-up patch would be nice: it
> seems like a one-time printk, indicating the FUA conversion is active,
> could be a help in case someone does care.
..
Seems like .text bloat to me.
But if you want it, I'll cook up patches for both ata_rwcmd_protocol()
in libata-core.c as well as sata_mv.c later on.
Cheers
next prev parent reply other threads:[~2009-04-18 1:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 15:27 [PATCH 01/02] sata_mv: tidy up qc->tf usage in qc_prep() functions Mark Lord
2009-04-13 15:29 ` [PATCH 02/02] sata_mv: workaround for multi_count errata sata24 Mark Lord
2009-04-13 15:36 ` Mark Lord
2009-04-13 17:25 ` Jeff Garzik
2009-04-13 17:36 ` Mark Lord
2009-04-13 15:40 ` Alan Cox
2009-04-13 15:44 ` Mark Lord
2009-04-13 15:46 ` Mark Lord
2009-04-17 23:03 ` Jeff Garzik
2009-04-18 1:11 ` Mark Lord [this message]
2009-04-17 22:59 ` libata git repo guide (was Re: [PATCH 01/02] sata_mv: tidy up qc->tf usage in qc_prep() functions) Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E928BF.5060402@rtr.ca \
--to=liml@rtr.ca \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).