From: Jeff Garzik <jeff@garzik.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
Jens Axboe <jens.axboe@oracle.com>,
rwheeler@redhat.com, snitzer@redhat.com, neilb@suse.de,
James.Bottomley@hansenpartnership.com, dgilbert@interlog.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 5 of 8] sd: Detect non-rotational devices
Date: Thu, 23 Apr 2009 09:33:47 -0400 [thread overview]
Message-ID: <49F06E3B.104@garzik.org> (raw)
In-Reply-To: <yq1r5zjbje2.fsf@sermon.lab.mkp.net>
Martin K. Petersen wrote:
>>>>>> "Matthew" == Matthew Wilcox <matthew@wil.cx> writes:
>
> Matthew> I already did that. The only problem is that you made me
> Matthew> include the stupid:
>
> Matthew> if (ata_id_major_version(args->id) > 7) {
>
> Matthew> so of course it doesn't work on any existing hardware. How
> Matthew> about applying this patch:
>
> Maybe we could incubate your patch in the next tree for a bit and see
> what breaks without the version check?
>
> We could even be somewhat conservative like we were with RC16 in SCSI.
> The SATA devices I have here with valid rotational flags all report
> version 7. I wonder if > 6 do the trick?
linux/ata.h illustrates the standard ATA rules for validating bits of
IDENTIFY DEVICE.
Just checking the version was always just a simplistic hack... we are
talking specifically about trusting values listed as undefined in the
relevant specs. That requires more, not less, gymnastics :)
Jeff
next prev parent reply other threads:[~2009-04-23 13:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 5:29 [PATCH 0 of 8] I/O topology patch kit Martin K. Petersen
2009-04-23 5:29 ` [PATCH 1 of 8] block: Expose stacked device queues in sysfs Martin K. Petersen
2009-04-23 5:29 ` [PATCH 2 of 8] block: Export I/O topology for block devices and partitions Martin K. Petersen
2009-04-23 10:51 ` Jens Axboe
2009-04-23 11:49 ` Matthew Wilcox
2009-04-23 11:55 ` Jens Axboe
2009-04-23 13:22 ` Matthew Wilcox
2009-04-23 13:30 ` Matthew Wilcox
2009-04-23 13:17 ` Martin K. Petersen
2009-04-23 18:13 ` Konrad Rzeszutek
2009-04-23 18:26 ` Ric Wheeler
2009-04-23 18:44 ` Matthew Wilcox
2009-04-23 18:34 ` Martin K. Petersen
2009-04-23 5:29 ` [PATCH 3 of 8] MD: Use new topology calls to indicate alignment and I/O sizes Martin K. Petersen
2009-04-23 5:29 ` [PATCH 4 of 8] sd: Physical block size and alignment support Martin K. Petersen
2009-04-23 16:37 ` Konrad Rzeszutek
2009-04-23 18:25 ` Martin K. Petersen
2009-04-23 18:44 ` Konrad Rzeszutek
2009-04-23 19:02 ` Martin K. Petersen
2009-04-23 5:29 ` [PATCH 5 of 8] sd: Detect non-rotational devices Martin K. Petersen
2009-04-23 10:52 ` Jens Axboe
2009-04-23 11:09 ` Jeff Garzik
2009-04-23 11:13 ` Jens Axboe
2009-04-23 11:22 ` Jeff Garzik
2009-04-23 11:38 ` Matthew Wilcox
2009-04-23 11:58 ` Jeff Garzik
2009-04-23 12:03 ` Jens Axboe
2009-04-23 13:16 ` Martin K. Petersen
2009-04-23 13:33 ` Jeff Garzik [this message]
2009-04-23 14:10 ` James Bottomley
2009-04-23 14:16 ` Matthew Wilcox
2009-04-23 14:39 ` Jeff Garzik
2009-04-23 17:25 ` Matthew Wilcox
2009-04-23 17:37 ` James Bottomley
2009-04-23 5:29 ` [PATCH 6 of 8] sd: Block limits VPD support Martin K. Petersen
2009-04-23 5:29 ` [PATCH 7 of 8] scsi_debug: Add support for physical block exponent and alignment Martin K. Petersen
2009-04-23 5:29 ` [PATCH 8 of 8] libata: Report disk alignment and physical block size Martin K. Petersen
2009-04-23 13:46 ` Matthew Wilcox
2009-04-23 14:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F06E3B.104@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dgilbert@interlog.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthew@wil.cx \
--cc=neilb@suse.de \
--cc=rwheeler@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).