From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 2/3] mg_disk: fix dependency on libata Date: Sun, 26 Apr 2009 00:02:29 -0400 Message-ID: <49F3DCD5.2070909@garzik.org> References: <200904251509.11912.bzolnier@gmail.com> <49F3D994.7020304@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:50359 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbZDZECh (ORCPT ); Sun, 26 Apr 2009 00:02:37 -0400 In-Reply-To: <49F3D994.7020304@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Bartlomiej Zolnierkiewicz , unsik Kim , linux-kernel@vger.kernel.org, Linux IDE mailing list Tejun Heo wrote: > Bartlomiej Zolnierkiewicz wrote: >> Add local copies of ata_id_string() and ata_id_c_string() to mg_disk >> so there is no need for the driver to depend on ATA and SCSI. >> >> Cc: unsik Kim >> Cc: Tejun Heo >> Signed-off-by: Bartlomiej Zolnierkiewicz > > Ah.. right, that's a rather large dependency to pull in just for the > string functions. Yeah, I think it would be better to keep local > copy at elast for now. > > Acked-by: Tejun Heo Actually... NVMHCI[1] uses the same style of id string extraction, even though its command set is wholly new and unrelated to ATA. I copied into drivers/block/nvmhci.c[2] id_string, id_c_string and another useful, generic routine: ata_wait_register. So, once nvmhci goes upstream, that will be a third copy... nvmhci still has rough edges, but it's mainly waiting on hardware "it works" verification at this point. Jeff [1] http://download.intel.com/standards/nvmhci/spec.pdf [2] 'nvmhci' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git