From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
unsik Kim <donari75@gmail.com>,
linux-kernel@vger.kernel.org,
Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2/3] mg_disk: fix dependency on libata
Date: Sun, 26 Apr 2009 00:11:46 -0400 [thread overview]
Message-ID: <49F3DF02.5030909@garzik.org> (raw)
In-Reply-To: <49F3DE55.8070302@kernel.org>
Tejun Heo wrote:
> Jeff Garzik wrote:
>> Actually... NVMHCI[1] uses the same style of id string extraction, even
>> though its command set is wholly new and unrelated to ATA. I copied
>> into drivers/block/nvmhci.c[2] id_string, id_c_string and another
>> useful, generic routine: ata_wait_register.
>>
>> So, once nvmhci goes upstream, that will be a third copy... nvmhci
>> still has rough edges, but it's mainly waiting on hardware "it works"
>> verification at this point.
>
> For two copies, copying seems to be the right way to go. For many
> more copies, making a library function is. Three is a difficult
> number. Maybe just make these inline functions for now?
<shrug> I'm just adding some data, I don't have a good suggestion :)
The functions do not change very often, so three copies is not
necessarily the end of the world.
Jeff
next prev parent reply other threads:[~2009-04-26 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200904251509.11912.bzolnier@gmail.com>
2009-04-26 4:04 ` [PATCH 2/3] mg_disk: fix dependency on libata Jeff Garzik
2009-04-26 9:53 ` Bartlomiej Zolnierkiewicz
[not found] ` <49F3D994.7020304@kernel.org>
2009-04-26 4:02 ` Jeff Garzik
2009-04-26 4:08 ` Tejun Heo
2009-04-26 4:11 ` Jeff Garzik [this message]
2009-04-26 9:39 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F3DF02.5030909@garzik.org \
--to=jeff@garzik.org \
--cc=bzolnier@gmail.com \
--cc=donari75@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).