From: Jeff Garzik <jeff@garzik.org>
To: Wolfgang Denk <wd@denx.de>
Cc: Feng Kan <fkan@amcc.com>,
linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org,
Mark Miesfeld <miesfeld@gmail.com>
Subject: Re: [PATCH 1/2] Added support for Designware SATA controller driver
Date: Fri, 01 May 2009 20:05:06 -0400 [thread overview]
Message-ID: <49FB8E32.1050100@garzik.org> (raw)
In-Reply-To: <20090501232040.3E59283420E8@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Feng Kan,
>
> In message <1241211767-32697-1-git-send-email-fkan@amcc.com> you wrote:
>> This adds support for the Designware SATA controller.
>>
>> Signed-off-by: Feng Kan <fkan@amcc.com>
>> Signed-off-by: Mark Miesfeld <miesfeld@gmail.com>
>> ---
>> drivers/ata/Kconfig | 10 +
>> drivers/ata/Makefile | 1 +
>> drivers/ata/sata_dwc.c | 2053 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 2064 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/ata/sata_dwc.c
>
> ...
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Mark Miesfeld <mmiesfeld@amcc.com>");
>> +MODULE_DESCRIPTION("DesignWare Cores SATA controller low lever driver");
> ------------------------------------------------------------^^^^^
>
> Guess that's a typo?
heh
> Hmm... that's 2000+ lines of code in a single file. Maybe this should
> be split?
A single file is just fine.
Jeff
prev parent reply other threads:[~2009-05-02 0:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 21:02 [PATCH 1/2] Added support for Designware SATA controller driver Feng Kan
2009-05-01 21:26 ` Scott Wood
2009-05-06 17:44 ` Feng Kan
2009-05-01 23:20 ` Wolfgang Denk
2009-05-02 0:05 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FB8E32.1050100@garzik.org \
--to=jeff@garzik.org \
--cc=fkan@amcc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miesfeld@gmail.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).