From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: New TRIM/UNMAP tree published (2009-05-02) Date: Mon, 04 May 2009 18:28:07 +0300 Message-ID: <49FF0987.8040608@panasas.com> References: <1238683047-13588-1-git-send-email-willy@linux.intel.com> <49D8A3D7.5070507@panasas.com> <20090503061150.GF10704@linux.intel.com> <20090503071619.GP8822@parisc-linux.org> <20090503144847.GR8822@parisc-linux.org> <49FDB21B.3080301@panasas.com> <20090503154216.GU8822@parisc-linux.org> <49FDC786.6070309@panasas.com> <49FDE3BB.505@garzik.org> <49FDE50A.4060503@garzik.org> <1241377472.5596.88.camel@mulgrave.int.hansenpartnership.com> <49FDEE64.5090302@garzik.org> <1241380067.5596.103.camel@mulgrave.int.hansenpartnership.com> <49FE1EFF.2050406@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f158.google.com ([209.85.220.158]:51932 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755728AbZEDP2P (ORCPT ); Mon, 4 May 2009 11:28:15 -0400 In-Reply-To: <49FE1EFF.2050406@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: James Bottomley , Matthew Wilcox , Jens Axboe , Hugh Dickins , Matthew Wilcox , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Bartlomiej Zolnierkiewicz , Mark Lord On 05/04/2009 01:47 AM, Jeff Garzik wrote: > James Bottomley wrote: >> The ideal for REQ_TYPE_DISCARD seems to be to force a page allocation >> tied to a bio when it's issued at the top. That way everyone has enough >> memory when it comes down the stack (both extents and WRITE SAME sector >> will fit into a page ... although only just for WRITE SAME on 4k >> sectors). > > Makes sense... > > Jeff > I second that, let the allocator of the request supply a buffer and free it on return/done. Perhaps with a general helper that does all that. Boaz