public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Darren Stevens <darren@stevens-zone.net>
To: tj@kernel.org
Cc: tourula@gmail.com, linux-ide@vger.kernel.org
Subject: [PATCH] pata_atiixp: Fix IDE detection on SB7xx
Date: Tue, 28 Mar 2017 16:57:16 +0100 (BST)	[thread overview]
Message-ID: <49ce56dc322.70129c23@auth.smtp.1and1.co.uk> (raw)

Commit: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port on
SB600/SB700) disabled the check for secondary ports on AMD SB700/710/750

While these chips have only 1 IDE port, it can be reconfigured on SB7xx
to appear as a secondary channel, especially when 'Legacy IDE emulation'
is enabled, breaking IDE detection on some boards with this chipset.

Fix by removing the check for SB7xx.

Fixes: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
on SB600/SB700)
Signed-off-by: Darren Stevens <Darren@stevens-zone.net>
---
 drivers/ata/pata_atiixp.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
index 6c9aa95..843bb20 100644
--- a/drivers/ata/pata_atiixp.c
+++ b/drivers/ata/pata_atiixp.c
@@ -278,9 +278,8 @@ static int atiixp_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
    };
    const struct ata_port_info *ppi[] = { &info, &info };
 
-   /* SB600/700 don't have secondary port wired */
-   if ((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE) ||
-       (pdev->device == PCI_DEVICE_ID_ATI_IXP700_IDE))
+   /* SB600 doesn't have secondary port wired */
+   if (pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE)
        ppi[1] = &ata_dummy_port_info;
 
    return ata_pci_bmdma_init_one(pdev, ppi, &atiixp_sht, NULL,
-- 
1.7.10.4



             reply	other threads:[~2017-03-28 16:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 15:57 Darren Stevens [this message]
2017-03-28 17:00 ` [PATCH] pata_atiixp: Fix IDE detection on SB7xx Tejun Heo
2017-03-30  9:08   ` Darren Stevens
2017-03-30 15:51     ` Tejun Heo
2017-03-29 10:34 ` [PATCH] " Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ce56dc322.70129c23@auth.smtp.1and1.co.uk \
    --to=darren@stevens-zone.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=tourula@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox