From: Darren Stevens <darren@stevens-zone.net>
To: Tejun Heo <tj@kernel.org>
Cc: tourula@gmail.com, linux-ide@vger.kernel.org
Subject: Re: pata_atiixp: Fix IDE detection on SB7xx
Date: Thu, 30 Mar 2017 10:08:52 +0100 (BST) [thread overview]
Message-ID: <49d09a00a4e.6d8687b5@auth.smtp.1and1.co.uk> (raw)
In-Reply-To: <20170328170048.GD28157@htj.duckdns.org>
Hello Tejun
On 28/03/2017, Tejun Heo wrote:
> Hello,
>
> On Tue, Mar 28, 2017 at 04:57:16PM +0100, Darren Stevens wrote:
>> Commit: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
>> on SB600/SB700) disabled the check for secondary ports on AMD
>> SB700/710/750
>
>> While these chips have only 1 IDE port, it can be reconfigured on SB7xx
>> to appear as a secondary channel, especially when 'Legacy IDE emulation'
>> is enabled, breaking IDE detection on some boards with this chipset.
>>
>> Fix by removing the check for SB7xx.
>>
>> Fixes: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
>> on SB600/SB700)
>> Signed-off-by: Darren Stevens <Darren@stevens-zone.net>
>
> Hmmm... I can replace the revert with this but can you please explain
> why we want this in the commit message? Also, it'd be nice to cc
> Markku and link to his report.
What would you prefer the commit message to say? I was only explaining why the
patch was needed.
I need to fix formatting anyway, as Sergei has pointed out, so either I rework
this or you revert as originally planned and I'll resubmit the original patch
for the SB600 only, whichever works best for you, I'm aware time is an issue
here.
I didn't include Markku as I'm not sure I should be adding people to the
Commit without their express permission.
I'm still quite new at this so sorry for causing all this trouble.
Regards
Darren
next prev parent reply other threads:[~2017-03-30 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 15:57 [PATCH] pata_atiixp: Fix IDE detection on SB7xx Darren Stevens
2017-03-28 17:00 ` Tejun Heo
2017-03-30 9:08 ` Darren Stevens [this message]
2017-03-30 15:51 ` Tejun Heo
2017-03-29 10:34 ` [PATCH] " Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49d09a00a4e.6d8687b5@auth.smtp.1and1.co.uk \
--to=darren@stevens-zone.net \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tourula@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox