[PATCH] pata_atiixp: Fix IDE detection on SB7xx

[PATCH] pata_atiixp: Fix IDE detection on SB7xx

[Darren Stevens]

Commit: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port on
SB600/SB700) disabled the check for secondary ports on AMD SB700/710/750

While these chips have only 1 IDE port, it can be reconfigured on SB7xx
to appear as a secondary channel, especially when 'Legacy IDE emulation'
is enabled, breaking IDE detection on some boards with this chipset.

Fix by removing the check for SB7xx.

Fixes: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
on SB600/SB700)
Signed-off-by: Darren Stevens <Darren@stevens-zone.net>
---
 drivers/ata/pata_atiixp.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
index 6c9aa95..843bb20 100644
--- a/drivers/ata/pata_atiixp.c
+++ b/drivers/ata/pata_atiixp.c
@@ -278,9 +278,8 @@ static int atiixp_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
    };
    const struct ata_port_info *ppi[] = { &info, &info };
 
-   /* SB600/700 don't have secondary port wired */
-   if ((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE) ||
-       (pdev->device == PCI_DEVICE_ID_ATI_IXP700_IDE))
+   /* SB600 doesn't have secondary port wired */
+   if (pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE)
        ppi[1] = &ata_dummy_port_info;
 
    return ata_pci_bmdma_init_one(pdev, ppi, &atiixp_sht, NULL,
-- 
1.7.10.4

Re: [PATCH] pata_atiixp: Fix IDE detection on SB7xx

[Tejun Heo]

Hello,

On Tue, Mar 28, 2017 at 04:57:16PM +0100, Darren Stevens wrote:
> Commit: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port on
> SB600/SB700) disabled the check for secondary ports on AMD SB700/710/750
> 
> While these chips have only 1 IDE port, it can be reconfigured on SB7xx
> to appear as a secondary channel, especially when 'Legacy IDE emulation'
> is enabled, breaking IDE detection on some boards with this chipset.
> 
> Fix by removing the check for SB7xx.
> 
> Fixes: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
> on SB600/SB700)
> Signed-off-by: Darren Stevens <Darren@stevens-zone.net>

Hmmm... I can replace the revert with this but can you please explain
why we want this in the commit message?  Also, it'd be nice to cc
Markku and link to his report.

Thanks.

-- 
tejun

Re: pata_atiixp: Fix IDE detection on SB7xx

[Darren Stevens]

Hello Tejun

On 28/03/2017, Tejun Heo wrote:
> Hello,
>
> On Tue, Mar 28, 2017 at 04:57:16PM +0100, Darren Stevens wrote:
>> Commit: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
>> on SB600/SB700) disabled the check for secondary ports on AMD
>> SB700/710/750
>
>> While these chips have only 1 IDE port, it can be reconfigured on SB7xx
>> to appear as a secondary channel, especially when 'Legacy IDE emulation'
>> is enabled, breaking IDE detection on some boards with this chipset.
>> 
>> Fix by removing the check for SB7xx.
>> 
>> Fixes: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
>> on SB600/SB700)
>> Signed-off-by: Darren Stevens <Darren@stevens-zone.net>
>
> Hmmm... I can replace the revert with this but can you please explain
> why we want this in the commit message?  Also, it'd be nice to cc
> Markku and link to his report.

What would you prefer the commit message to say? I was only explaining why the
patch was needed.

I need to fix formatting anyway, as Sergei has pointed out, so either I rework
this or you revert as originally planned and I'll resubmit the original patch
for the SB600 only, whichever works best for you, I'm aware time is an issue
here.

I didn't include Markku as I'm not sure I should be adding people to the
Commit without their express permission.

I'm still quite new at this so sorry for causing all this trouble.

Regards
Darren

Re: pata_atiixp: Fix IDE detection on SB7xx

[Tejun Heo]

Hello,

On Thu, Mar 30, 2017 at 10:08:52AM +0100, Darren Stevens wrote:
> What would you prefer the commit message to say? I was only explaining why the
> patch was needed.

Oh, I want it to explain why it matters to mark the unused port dummy.
It does reduce the probing time, right?

> I need to fix formatting anyway, as Sergei has pointed out, so either I rework
> this or you revert as originally planned and I'll resubmit the original patch
> for the SB600 only, whichever works best for you, I'm aware time is an issue
> here.

Can you please generate the patch on top of the following branch?

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git for-4.11-fixes

The revert was days ago, so I don't wanna replace it at this point.
Let's just do an incremnetal patch on top.

> I didn't include Markku as I'm not sure I should be adding people to the
> Commit without their express permission.

I see.  I sometimes try to get permission if the person only wrote off
list but once things are on the mailing list I don't think there's
anything to worry about.  Just cc them.

> I'm still quite new at this so sorry for causing all this trouble.

No worries.  You're doing great. :)

Thanks.

-- 
tejun

Re: [PATCH] pata_atiixp: Fix IDE detection on SB7xx

[Sergei Shtylyov]

Hello!

On 3/28/2017 6:57 PM, Darren Stevens wrote:

> Commit: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port on

    Need space before the 1st paren, and summary enclosed in (""), not just ().

> SB600/SB700) disabled the check for secondary ports on AMD SB700/710/750
>
> While these chips have only 1 IDE port, it can be reconfigured on SB7xx
> to appear as a secondary channel, especially when 'Legacy IDE emulation'
> is enabled, breaking IDE detection on some boards with this chipset.
>
> Fix by removing the check for SB7xx.
>
> Fixes: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
> on SB600/SB700)

    Required the same standardized format as described above.

> Signed-off-by: Darren Stevens <Darren@stevens-zone.net>
[...]

MBR, Sergei