* [PATCH] libata: Add multi-count transfer debugging
@ 2009-05-06 13:45 Carl-Daniel Hailfinger
2009-05-07 5:02 ` Robert Hancock
0 siblings, 1 reply; 2+ messages in thread
From: Carl-Daniel Hailfinger @ 2009-05-06 13:45 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, Ward Vandewege
On my Asus M2A-VM (SB600) board, the SATA disks use multi-count
transfers only with some BIOS variants.
Dumping the relevant config words helps debugging a lot.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
--- a/drivers/ata/libata-core.c 2009-05-06 14:24:32.000000000 +0200
+++ b/drivers/ata/libata-core.c 2009-05-06 15:27:06.000000000 +0200
@@ -2390,11 +2390,11 @@
/* print device capabilities */
if (ata_msg_probe(ap))
ata_dev_printk(dev, KERN_DEBUG,
- "%s: cfg 49:%04x 82:%04x 83:%04x 84:%04x "
- "85:%04x 86:%04x 87:%04x 88:%04x\n",
+ "%s: cfg 47:%04x 49:%04x 59:%04x 82:%04x 83:%04x"
+ " 84:%04x 85:%04x 86:%04x 87:%04x 88:%04x\n",
__func__,
- id[49], id[82], id[83], id[84],
- id[85], id[86], id[87], id[88]);
+ id[47], id[49], id[59], id[82], id[83],
+ id[84], id[85], id[86], id[87], id[88]);
/* initialize to-be-configured parameters */
dev->flags &= ~ATA_DFLAG_CFG_MASK;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: Add multi-count transfer debugging
2009-05-06 13:45 [PATCH] libata: Add multi-count transfer debugging Carl-Daniel Hailfinger
@ 2009-05-07 5:02 ` Robert Hancock
0 siblings, 0 replies; 2+ messages in thread
From: Robert Hancock @ 2009-05-07 5:02 UTC (permalink / raw)
To: Carl-Daniel Hailfinger; +Cc: Jeff Garzik, linux-ide, Ward Vandewege
Carl-Daniel Hailfinger wrote:
> On my Asus M2A-VM (SB600) board, the SATA disks use multi-count
> transfers only with some BIOS variants.
> Dumping the relevant config words helps debugging a lot.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>
> --- a/drivers/ata/libata-core.c 2009-05-06 14:24:32.000000000 +0200
> +++ b/drivers/ata/libata-core.c 2009-05-06 15:27:06.000000000 +0200
> @@ -2390,11 +2390,11 @@
> /* print device capabilities */
> if (ata_msg_probe(ap))
> ata_dev_printk(dev, KERN_DEBUG,
> - "%s: cfg 49:%04x 82:%04x 83:%04x 84:%04x "
> - "85:%04x 86:%04x 87:%04x 88:%04x\n",
> + "%s: cfg 47:%04x 49:%04x 59:%04x 82:%04x 83:%04x"
> + " 84:%04x 85:%04x 86:%04x 87:%04x 88:%04x\n",
> __func__,
> - id[49], id[82], id[83], id[84],
> - id[85], id[86], id[87], id[88]);
> + id[47], id[49], id[59], id[82], id[83],
> + id[84], id[85], id[86], id[87], id[88]);
>
> /* initialize to-be-configured parameters */
> dev->flags &= ~ATA_DFLAG_CFG_MASK;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Keep in mind that multi-count transfers are only meaningful for PIO
read/write commands (it controls the number of sectors transferred for
each DRQ assertion), which would only be used if the device didn't
support DMA - unlikely for SATA..
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-07 5:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-06 13:45 [PATCH] libata: Add multi-count transfer debugging Carl-Daniel Hailfinger
2009-05-07 5:02 ` Robert Hancock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).