From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Kan Subject: Re: [PATCH 1/2] Added support for Designware SATA controller driver Date: Wed, 06 May 2009 10:44:24 -0700 Message-ID: <4A01CC78.3060004@amcc.com> References: <1241211767-32697-1-git-send-email-fkan@amcc.com> <49FB68F2.10301@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from sdcmail01.amcc.com ([198.137.200.72]:25525 "EHLO sdcmail01.amcc.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbZEFRox (ORCPT ); Wed, 6 May 2009 13:44:53 -0400 In-Reply-To: <49FB68F2.10301@freescale.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Scott Wood Cc: linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org, Mark Miesfeld Hi Scott: I agree with your statement, however this driver is wrapped with this AHB DMA controller. It would be very hard for it to work on non 460EX platforms. I can expand the depend in the future if it is available on more cores. Thanks Feng Kan Scott Wood wrote: > Feng Kan wrote: >> This adds support for the Designware SATA controller. >> >> Signed-off-by: Feng Kan >> Signed-off-by: Mark Miesfeld >> --- >> drivers/ata/Kconfig | 10 + >> drivers/ata/Makefile | 1 + >> drivers/ata/sata_dwc.c | 2053 >> ++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 2064 insertions(+), 0 deletions(-) >> create mode 100644 drivers/ata/sata_dwc.c >> >> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig >> index 0bcf264..c3d0b24 100644 >> --- a/drivers/ata/Kconfig >> +++ b/drivers/ata/Kconfig >> @@ -72,6 +72,16 @@ config SATA_FSL >> >> If unsure, say N. >> >> +config SATA_DWC >> + tristate "DesignWare Cores SATA support" >> + depends on 460EX > > That "depends" looks too specific -- we don't want to grow a list if > this controller gets added to other chips. > > Only depend on what this driver actually needs in order to function. > > -Scott