From: Jeff Garzik <jeff@garzik.org>
To: Konstantinos Margaritis <markos@codex.gr>
Cc: linux-ide@vger.kernel.org,
Lennert Buytenhek <buytenh@wantstofly.org>,
Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Subject: Re: [PATCH] fix sata_sil compilation on non-DMI platforms
Date: Mon, 11 May 2009 14:12:06 -0400 [thread overview]
Message-ID: <4A086A76.3090008@garzik.org> (raw)
In-Reply-To: <200905062009.28087.markos@codex.gr>
Konstantinos Margaritis wrote:
> (not subscribed please CC me)
>
> I tried to compile sata_sil on a 2.6.27 kernel on powerpc32 and I found that
> it failed to compile -lots of dmi related errors. I found that I had to
> include the broken_systems handling code in #ifdef CONFIG_DMI (DMI is not
> supported on platforms other than i386/x86_64).
>
> Lennert on #mklinux told me that this commit broke the non-dmi support, and
> that a similar patch to mine is used on ARM systems :
>
> commit e57db7bde7bff95ae812736ca00c73bd5271455b
> SATA Sil: Blacklist system that spins off disks during ACPI power off
>
> With this patch, sata_sil compiles on ppc (and I guess on other platforms).
> I'm using it for a while with no problems with a Delock 4-port SATA PCI card.
(CC'ing various Lennerts)
What is the breakage?
Ideally the DMI subsystem should be provided wrappers for platforms
without DMI, rendering patches like this unnecessary.
Jeff
next prev parent reply other threads:[~2009-05-11 18:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 17:09 [PATCH] fix sata_sil compilation on non-DMI platforms Konstantinos Margaritis
2009-05-11 18:12 ` Jeff Garzik [this message]
2009-05-11 18:23 ` Lennert Buytenhek
2009-05-11 18:44 ` Alan Cox
2009-05-11 22:31 ` Benjamin Herrenschmidt
2009-05-11 19:30 ` Lennart Sorensen
2009-05-12 9:09 ` Mikael Pettersson
2009-05-12 9:26 ` Jeff Garzik
2009-05-15 11:11 ` Mikael Pettersson
2009-05-15 17:49 ` Jeff Garzik
2009-05-15 22:46 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A086A76.3090008@garzik.org \
--to=jeff@garzik.org \
--cc=buytenh@wantstofly.org \
--cc=linux-ide@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=markos@codex.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).