From: Jeff Garzik <jeff@garzik.org>
To: petkovbb@gmail.com, Tejun Heo <htejun@gmail.com>,
Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: fix suspend/resume for ATA SEMB devices
Date: Mon, 11 May 2009 14:34:32 -0400 [thread overview]
Message-ID: <4A086FB8.6020509@garzik.org> (raw)
In-Reply-To: <20090426143836.GA3643@liondog.tnic>
Borislav Petkov wrote:
> From: Borislav Petkov <petkovbb@gmail.com>
> Date: Sun, 26 Apr 2009 16:33:34 +0200
> Subject: [PATCH] libata: fix suspend/resume for ATA SEMB devices
>
> 79b42babbac2a5a522b8e269fb2811b6e1063030 fixed identifying ATA devices
> reporting 3c/c3 signature which belongs to SEMB devices now. However,
> suspending the machine with such device (WDC WD2500AAJS-6 01.0) fails
> with the following:
>
> hda: host max PIO4 wanted PIO255(auto-tune) selected PIO4
> hda: UDMA/100 mode selected
> hdb: host max PIO4 wanted PIO255(auto-tune) selected PIO4
> hdb: UDMA/66 mode selected
> sd 1:0:0:0: [sda] Starting disk
> ata5: SATA link down (SStatus 0 SControl 300)
> ata1: SATA link down (SStatus 0 SControl 300)
> ata3: SATA link down (SStatus 0 SControl 300)
> ata6: SATA link down (SStatus 0 SControl 300)
> ata2: softreset failed (device not ready)
> ata2: failed due to HW bug, retry pmp=0
> ata4: softreset failed (device not ready)
> ata4: failed due to HW bug, retry pmp=0
> ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> ata2.00: class mismatch 1 != 7
> ata2.00: revalidation failed (errno=-19)
> ata2: limiting SATA link speed to 1.5 Gbps
> ata4.00: configured for UDMA/133
> ata2: softreset failed (device not ready)
> ata2: failed due to HW bug, retry pmp=0
> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 310)
> ata2.00: class mismatch 1 != 7
> ata2.00: revalidation failed (errno=-19)
> ata2.00: disabled
> sd 1:0:0:0: rejecting I/O to offline device
> sd 1:0:0:0: [sda] START_STOP FAILED
> sd 1:0:0:0: [sda] Result: hostbyte=0x01 driverbyte=0x00
> PM: Device 1:0:0:0 failed to thaw: error 65536
> sd 3:0:0:0: [sdb] Starting disk
>
> due to a class mismatch in ata_dev_revalidate(). Fix it by adding the
> ATA_DEV_SEMB device class to the check.
>
> CC: Tejun Heo <htejun@gmail.com>
> CC: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
> ---
> drivers/ata/libata-core.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
applied
prev parent reply other threads:[~2009-05-11 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 14:38 [PATCH] libata: fix suspend/resume for ATA SEMB devices Borislav Petkov
2009-04-26 22:26 ` Tejun Heo
2009-05-09 15:13 ` Borislav Petkov
2009-05-09 15:48 ` Tejun Heo
2009-05-11 18:34 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A086FB8.6020509@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).