From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: Use IGN_SIMPLEX for ALi
Date: Wed, 13 May 2009 19:56:28 +0400 [thread overview]
Message-ID: <4A0AEDAC.1020202@ru.mvista.com> (raw)
In-Reply-To: <20090513140201.11247.76226.stgit@t61.ukuu.org.uk>
Hello.
Alan Cox wrote:
> Some ALi devices report simplex if they have been disabled and re-enabled, and
> restoring the byte does not work. Ignore it - the needed supporting logic is
> already present for the SATA ULi ports.
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Whitespace police on guard. :-)
> diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
> index 751b7ea..fc9c5d6 100644
> --- a/drivers/ata/pata_ali.c
> +++ b/drivers/ata/pata_ali.c
> @@ -497,14 +497,16 @@ static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
> };
> /* Revision 0x20 added DMA */
> static const struct ata_port_info info_20 = {
> - .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
> + .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48 |
> + ATA_FLAG_IGN_SIMPLEX,
> .pio_mask = ATA_PIO4,
> .mwdma_mask = ATA_MWDMA2,
> .port_ops = &ali_20_port_ops
> };
> /* Revision 0x20 with support logic added UDMA */
> static const struct ata_port_info info_20_udma = {
> - .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
> + .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48 |
> + ATA_FLAG_IGN_SIMPLEX,
> .pio_mask = ATA_PIO4,
> .mwdma_mask = ATA_MWDMA2,
> .udma_mask = ATA_UDMA2,
> @@ -512,7 +514,8 @@ static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
> };
> /* Revision 0xC2 adds UDMA66 */
> static const struct ata_port_info info_c2 = {
> - .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
> + .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48 |
> + ATA_FLAG_IGN_SIMPLEX,
> .pio_mask = ATA_PIO4,
> .mwdma_mask = ATA_MWDMA2,
> .udma_mask = ATA_UDMA4,
> @@ -520,7 +523,8 @@ static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
> };
> /* Revision 0xC3 is UDMA66 for now */
> static const struct ata_port_info info_c3 = {
> - .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
> + .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48 |
> + ATA_FLAG_IGN_SIMPLEX,
> .pio_mask = ATA_PIO4,
> .mwdma_mask = ATA_MWDMA2,
> .udma_mask = ATA_UDMA4,
> @@ -528,7 +532,8 @@ static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
> };
> /* Revision 0xC4 is UDMA100 */
> static const struct ata_port_info info_c4 = {
> - .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
> + .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48 |
> + ATA_FLAG_IGN_SIMPLEX,
Why it's always so far to the right?
> .pio_mask = ATA_PIO4,
> .mwdma_mask = ATA_MWDMA2,
> .udma_mask = ATA_UDMA5,
> @@ -536,7 +541,7 @@ static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
> };
> /* Revision 0xC5 is UDMA133 with LBA48 DMA */
> static const struct ata_port_info info_c5 = {
> - .flags = ATA_FLAG_SLAVE_POSS,
> + .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_IGN_SIMPLEX,
Extra space here.
> .pio_mask = ATA_PIO4,
> .mwdma_mask = ATA_MWDMA2,
> .udma_mask = ATA_UDMA6,
MBR, Sergei
next prev parent reply other threads:[~2009-05-13 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 14:01 [PATCH 0/2] Series short description Alan Cox
2009-05-13 14:02 ` [PATCH 1/2] libata: Use IGN_SIMPLEX for ALi Alan Cox
2009-05-13 15:56 ` Sergei Shtylyov [this message]
2009-05-13 16:11 ` Alan Cox
2009-05-20 20:11 ` Jeff Garzik
2009-05-13 14:02 ` [PATCH 2/2] ata_piix: Enable parallel scan Alan Cox
2009-06-10 15:06 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0AEDAC.1020202@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).