From: Jeff Garzik <jeff@garzik.org>
To: David Milburn <dmilburn@redhat.com>
Cc: mikpe@it.uu.se, tj@kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH #sx4] sata_sx4: fixup interrupt handling
Date: Wed, 13 May 2009 19:26:35 -0400 [thread overview]
Message-ID: <4A0B572B.7040302@garzik.org> (raw)
In-Reply-To: <20090513230221.GB5863@dhcp-210.hsv.redhat.com>
David Milburn wrote:
> Issuing ATA_CMD_SET_FEATURES (0xef) times out because
> pdc20621_interrupt ignores command completion since
> ATA_TFLAG_POLLING flag is set.
>
> This has already been fixed for sata_promise:
>
> commit 51b94d2a5a90d4800e74d7348bcde098a28f4fb3
> Author: Tejun Heo <htejun@gmail.com>
> Date: Fri Jun 8 13:46:55 2007 -0700
>
> sata_promise: use TF interface for polling NODATA commands
>
> Also, this patch includes Mikael's original patches:
>
> http://marc.info/?l=linux-ide&m=121135828227724&w=2
> http://marc.info/?l=linux-ide&m=121144512109826&w=2
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> ---
> drivers/ata/sata_sx4.c | 22 +++++++++-------------
> 1 files changed, 9 insertions(+), 13 deletions(-)
Good spotting...
Is this on top of #sx4 or upstream?
Jeff
next prev parent reply other threads:[~2009-05-13 23:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 23:02 [PATCH #sx4] sata_sx4: fixup interrupt handling David Milburn
2009-05-13 23:26 ` Jeff Garzik [this message]
2009-05-13 23:39 ` David Milburn
2009-05-13 23:27 ` Jeff Garzik
2009-05-13 23:42 ` David Milburn
2009-05-14 14:07 ` David Milburn
2009-05-15 18:08 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0B572B.7040302@garzik.org \
--to=jeff@garzik.org \
--cc=dmilburn@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).