Re: [PATCH] fix sata_sil compilation on non-DMI platforms

[Jeff Garzik <jeff@garzik.org>]

Mikael Pettersson wrote:
> Ok I've checked now, and the breakage is that the commit referenced
> above added dmi stuff to sata_sil.c without an #include <linux/dmi.h>,
> and that broke !x86 builds:

Great!  Thanks for checking.


> drivers/ata/sata_sil.c: In function 'sil_broken_system_poweroff':
> drivers/ata/sata_sil.c:713: error: implicit declaration of function 'dmi_first_match'
> drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast
> 
> x86 builds work because they drag in dmi.h indirectly via some other header.
> 
> The follow-up commit 1737ef7598d3515fdc11cb9ba7e054f334404e04
> "sata_sil: Fix build breakage" added #include <linux/dmi.h> which
> made !x86 builds work again. 2.6.29-rc3 was released in the window
> between these two commits so it had this build breakage.
> 
> So the problem is not that <linux/dmi.h> doesn't work, but that
> someone apparently backported e57db7bde7bff95ae812736ca00c73bd5271455b
> to 2.6.27 but not 1737ef7598d3515fdc11cb9ba7e054f334404e04.

OK, so it sounds like upstream is OK, and 2.6.27.x needs 
1737ef7598d3515fdc11cb9ba7e054f334404e04

Thanks,

	Jeff