From: Tejun Heo <htejun@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Boaz Harrosh <bharrosh@panasas.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Borislav Petkov <petkovbb@googlemail.com>,
Pete Zaitcev <zaitcev@redhat.com>,
Eric Moore <Eric.Moore@lsi.com>,
"Darrick J. Wong" <djwong@us.ibm.com>
Subject: Re: [PATCH block#for-2.6.31 2/3] block: set rq->resid_len to blk_rq_bytes() on issue
Date: Sat, 16 May 2009 22:48:29 +0900 [thread overview]
Message-ID: <4A0EC42D.2080905@gmail.com> (raw)
In-Reply-To: <4A0EB1AD.6050806@ru.mvista.com>
Hello, Sergei.
Sergei Shtylyov wrote:
>> Heh... there's a reason I mentioned the original commit. The original
>> code was
>>
>> if (ret > 0) {
>> /* positive number is the untransferred residual */
>> rsp->data_len = ret;
>> req->data_len = 0;
>> ret = 0;
>> } else if (ret == 0) {
>> rsp->data_len = 0;
>> req->data_len = 0;
>> }
>>
>
> But still,
>
> req->data_len = 0;
>
> is common between both branches, so could be moved after the *if*
> statement.
Yeah, sure, feel free to submit a patch, but I don't know. Does it
even matter at all as long as the intention is clear?
Thanks.
--
tejun
next prev parent reply other threads:[~2009-05-16 13:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4A0D86DB.9000203@kernel.org>
2009-05-15 15:18 ` [PATCH block#for-2.6.31 2/3] block: set rq->resid_len to blk_rq_bytes() on issue Tejun Heo
2009-05-15 17:31 ` [PATCH block#for-2.6.31 1/3] ub: use __blk_end_request_all() Pete Zaitcev
2009-05-15 22:19 ` Tejun Heo
[not found] ` <4A0D87D2.7090806@gmail.com>
2009-05-15 15:19 ` [PATCH block#for-2.6.31 3/3] bio: always copy back data for copied kernel requests Tejun Heo
2009-05-15 15:38 ` [PATCH block#for-2.6.31 2/3] block: set rq->resid_len to blk_rq_bytes() on issue Sergei Shtylyov
2009-05-15 22:18 ` Tejun Heo
2009-05-16 12:29 ` Sergei Shtylyov
2009-05-16 13:48 ` Tejun Heo [this message]
2009-05-15 17:29 ` Pete Zaitcev
2009-05-15 22:14 ` Tejun Heo
2009-05-15 23:16 ` Pete Zaitcev
2009-05-16 0:14 ` Tejun Heo
2009-05-16 0:18 ` [PATCH UPDATED " Tejun Heo
2009-05-16 7:13 ` [PATCH " Borislav Petkov
2009-05-16 13:52 ` Tejun Heo
[not found] ` <4A0E0650.1020500@gmail.com>
2009-05-17 8:48 ` [PATCH UPDATED " Boaz Harrosh
2009-05-17 11:32 ` Tejun Heo
2009-05-17 11:41 ` Tejun Heo
2009-05-17 12:05 ` [PATCH UPDATED2 " Tejun Heo
2009-05-18 12:49 ` Jens Axboe
2009-05-19 9:14 ` Tejun Heo
2009-05-19 9:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0EC42D.2080905@gmail.com \
--to=htejun@gmail.com \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bharrosh@panasas.com \
--cc=bzolnier@gmail.com \
--cc=djwong@us.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=petkovbb@googlemail.com \
--cc=sshtylyov@ru.mvista.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).