Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice(

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Krzysztof Halasa wrote:

>>>  			} else {
>>>  				floppy->blocks = blocks;
>>>  				floppy->block_size = length;
>>>  				floppy->bs_factor = length / 512;
>>>  				if (floppy->bs_factor != 1)
>>> -					printk(KERN_NOTICE PFX "%s: Warning: "
>>> -					       "non 512 bytes block size not "
>>> -					       "fully supported\n",
>>> -					       drive->name);
>>> +					pr_notice(PFX "%s: Warning: non 512 bytes block size not fully supported\n",
>>>   
>>>       
>>   Again.
>>     
>
> (> 80 chars in line)
>
> Though I think most people would agree that the latter is much better,
> no?
>   

   Don't know about most people but I don't find 120-column lines better 
(being recently imposed 65-column limit on the patch description by some 
people :-).

> I think removal (rewording) of this rule has already been agreed upon,
> though not exactly yet codified.
>   

   Again, don't know about that but that would be against my personal 
preference. Also, if still not codified, it won't pass chackpatch.pl, so 
should be fixed.

MBR, Sergei