From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice( Date: Mon, 18 May 2009 17:38:28 +0400 Message-ID: <4A1164D4.8000509@ru.mvista.com> References: <3ff9e9c7a8918f4d5f7bab5590f46073a196a4bf.1242609804.git.joe@perches.com> <4A11343C.5070809@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:51917 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751727AbZERNie (ORCPT ); Mon, 18 May 2009 09:38:34 -0400 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Krzysztof Halasa Cc: Joe Perches , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Borislav Petkov Hello. Krzysztof Halasa wrote: >>> } else { >>> floppy->blocks = blocks; >>> floppy->block_size = length; >>> floppy->bs_factor = length / 512; >>> if (floppy->bs_factor != 1) >>> - printk(KERN_NOTICE PFX "%s: Warning: " >>> - "non 512 bytes block size not " >>> - "fully supported\n", >>> - drive->name); >>> + pr_notice(PFX "%s: Warning: non 512 bytes block size not fully supported\n", >>> >>> >> Again. >> > > (> 80 chars in line) > > Though I think most people would agree that the latter is much better, > no? > Don't know about most people but I don't find 120-column lines better (being recently imposed 65-column limit on the patch description by some people :-). > I think removal (rewording) of this rule has already been agreed upon, > though not exactly yet codified. > Again, don't know about that but that would be against my personal preference. Also, if still not codified, it won't pass chackpatch.pl, so should be fixed. MBR, Sergei