From: Tejun Heo <htejun@gmail.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-ide@vger.kernel.org, jeff@garzik.org
Subject: Re: ibata: get rid of ATA_MAX_QUEUE loop in ata_qc_complete_multiple() v2
Date: Wed, 20 May 2009 16:46:27 +0900 [thread overview]
Message-ID: <4A13B553.6010209@gmail.com> (raw)
In-Reply-To: <20090520074439.GJ11363@kernel.dk>
Jens Axboe wrote:
> We very rarely (if ever) complete more than one command in the
> sactive mask at the time, even for extremely high IO rates. So
> looping over the entire range of possible tags is pointless,
> instead use __ffs() to just find the completed tags directly.
>
> Updated to clear the tag from the done_mask instead of shifting
> done_mask down as suggested by From: Tejun Heo <htejun@gmail.com>
> Verified with a user space tester to produce the same results.
>
> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2009-05-20 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 7:44 ibata: get rid of ATA_MAX_QUEUE loop in ata_qc_complete_multiple() v2 Jens Axboe
2009-05-20 7:46 ` Tejun Heo [this message]
2009-05-20 7:49 ` Jeff Garzik
2009-05-20 7:58 ` Jens Axboe
2009-05-20 20:11 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A13B553.6010209@gmail.com \
--to=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).