Re: [PATCH 3/4] ata_piix: Turn on hotplugging support for older chips

[Jeff Garzik <jeff@garzik.org>]

Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
> 
> We can't do this for the later ones as they have all sorts of magic boot
> time stuff that needs reviewing and the like. However we can do it for the
> older ones and it turns out we need to as some IBM docking stations have a
> second PIIX series device in them and without this change you can't use it
> very well
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  drivers/ata/ata_piix.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index d51a17c..3434468 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -1500,8 +1500,8 @@ static int __devinit piix_init_one(struct pci_dev *pdev,
>  		dev_printk(KERN_DEBUG, &pdev->dev,
>  			   "version " DRV_VERSION "\n");
>  
> -	/* no hotplugging support (FIXME) */
> -	if (!in_module_init)
> +	/* no hotplugging support for later devices (FIXME) */
> +	if (!in_module_init && ent->driver_data >= ich5_sata)
>  		return -ENODEV;

applied