From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 3/4] ata_piix: Turn on hotplugging support for older chips Date: Wed, 20 May 2009 16:12:19 -0400 Message-ID: <4A146423.4090801@garzik.org> References: <20090506160612.24191.90737.stgit@t61.ukuu.org.uk> <20090506160947.24191.32143.stgit@t61.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:50451 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753345AbZETUMU (ORCPT ); Wed, 20 May 2009 16:12:20 -0400 In-Reply-To: <20090506160947.24191.32143.stgit@t61.ukuu.org.uk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: linux-ide@vger.kernel.org Alan Cox wrote: > From: Alan Cox > > We can't do this for the later ones as they have all sorts of magic boot > time stuff that needs reviewing and the like. However we can do it for the > older ones and it turns out we need to as some IBM docking stations have a > second PIIX series device in them and without this change you can't use it > very well > > Signed-off-by: Alan Cox > --- > > drivers/ata/ata_piix.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c > index d51a17c..3434468 100644 > --- a/drivers/ata/ata_piix.c > +++ b/drivers/ata/ata_piix.c > @@ -1500,8 +1500,8 @@ static int __devinit piix_init_one(struct pci_dev *pdev, > dev_printk(KERN_DEBUG, &pdev->dev, > "version " DRV_VERSION "\n"); > > - /* no hotplugging support (FIXME) */ > - if (!in_module_init) > + /* no hotplugging support for later devices (FIXME) */ > + if (!in_module_init && ent->driver_data >= ich5_sata) > return -ENODEV; applied