Re: EP93xx PIO IDE driver proposal

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Bartlomiej Zolnierkiewicz wrote:

>>Here's the revised patches, according to the changes you suggested.

> Thanks, I applied set_pio_mode.patch with the following minor fixup:

> @@ -1035,7 +1035,7 @@
>  
>  	ide_port_for_each_dev(i, drive, hwif) {
>  		/*
> -		 * default to PIO Mode 0 before we  figure out
> +		 * default to PIO Mode 0 before we figure out
>  		 * the most suited mode for the attached device
>  		 */
>  		if (port_ops && port_ops->set_pio_mode)

> and will apply the following version of ide_drive_data.patch
> (unless there are some major complains):

> From: Joao Ramos <joao.ramos@inov.pt>
> Subject: ide: do not access ide_drive_t 'drive_data' field directly

> Change ide_drive_t 'drive_data' field from 'unsigned int' type to 'void *'
> type, allowing a wider range of values/types to be stored in this field.

> Added 'ide_get_drivedata' and 'ide_set_drivedata' helpers to get and set
> the 'drive_data' field.

> Fixed all host drivers to maintain coherency with the change in the
> 'drive_data' field type.

> Signed-off-by: Joao Ramos <joao.ramos@inov.pt>
> [bart: fix qd65xx build, cast to 'unsigned long', minor Coding Style fixups]
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.montavista.com>

MBR, Sergei