Re: [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings for pr_<level> and dev_<level>

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Joe Perches wrote:

>>>-		dev_err(&drive->gendev, "%s: packet size (0x%02x) is not 12 "
>>>-			"bytes\n", s, packet_size);
>>>+		dev_err(&drive->gendev,
>>>+			"%s: packet size (0x%02x) is not 12 bytes\n",

>>   When the message is broken by the format specifier, turning it into 
>>one liner can hardly help seraching...

> grep "is not 12 bytes"

    Yes, carrying "is not 12 " to that would have made sense.

>>   Oh noes, the indentation...

> trade-offs...

>>>+	"(IO,CoD != (0,1) while issuing a packet command, retrying\n");

>>   Sigh...

> You seem to sigh a lot.  ;)

    I'm not sure you'll like "ugh" better.

>>>+		"unexpected interrupt, status=0x%02x, count=%ld\n",

>>   Hardly won anything...
>>
>>>+ "%s side 80-wire cable detection failed, limiting max speed to UDMA33\n",
>>
>>    Will you really use the full message to serch here?
>>
>>>+		 "probing with STATUS(0x%02x) instead of ALTSTATUS(0x%02x)\n",
>>
>>   Same comment about the line broken by the format specifiers. This 
>>wins absolutely nothing.

> grep "STATUS.*ALTSTATUS"

    Hm, I didn't think about wildcards. Yet I find search for "probing with 
STATUS" more probable.

>>>+		"no response (status = 0x%02x), resetting drive\n",
>>
>>   And again...

> grep "response.*resetting"

    I'd grep for "no response (status =" in this case.

> cheers, Joe

MBR, Sergei