* broken ide-tape
@ 2009-05-31 14:52 Jiri Slaby
2009-05-31 16:17 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2009-05-31 14:52 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Bartlomiej Zolnierkiewicz, linux-ide, LKML
Hi,
ide-tape is broken since commit 346331f82823682fb5c2df6e827db25d95cc2e92
(ide-tape: remove atomic test/set macros for packet commands)
from Apr 18 2008.
The commit introduced flags which are defined as (1 << nr) and uses them
in {clear,set,test}_bit. And hence it must oops on each do_request.
Is it worth fixing (something like ilog2 added to each bit operation) or
is a complete removal of the driver better "fix"?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: broken ide-tape
2009-05-31 14:52 broken ide-tape Jiri Slaby
@ 2009-05-31 16:17 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2009-05-31 16:17 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Bartlomiej Zolnierkiewicz, linux-ide, LKML
On Sun, May 31, 2009 at 04:52:08PM +0200, Jiri Slaby wrote:
> Hi,
>
> ide-tape is broken since commit 346331f82823682fb5c2df6e827db25d95cc2e92
> (ide-tape: remove atomic test/set macros for packet commands)
> from Apr 18 2008.
>
> The commit introduced flags which are defined as (1 << nr) and uses them
> in {clear,set,test}_bit. And hence it must oops on each do_request.
/me ducks behind the couch.
Ouch, that _is_ dumb, sorry. This is because we wanted to keep the
atomic ops for the pipeline handling (which got removed) and use
simple flags for the rest. And so the flags got mixed up and the mess
unleashed...
> Is it worth fixing (something like ilog2 added to each bit operation) or
> is a complete removal of the driver better "fix"?
Actually, the driver needs to be reaudited and fixed properly - we still
have some users left. I'm looking into it.
Thanks for catching that.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-31 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-31 14:52 broken ide-tape Jiri Slaby
2009-05-31 16:17 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).