From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/3] ide: remove superfluous SELECT_MASK() call from ide_driveid_update()
Date: Tue, 02 Jun 2009 19:47:35 +0400 [thread overview]
Message-ID: <4A254997.1080409@ru.mvista.com> (raw)
In-Reply-To: <200906012352.57741.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> We always call SELECT_MASK(drive, 0) after ide_dev_read_id() call
> so there is no need to do it again in the error path.
> Moreover with the combination of HPT36x controller and the drive on
> the quirk_drives[] list this can result in superfluous enable_irq()
> call which in turn will trigger WARN() in __enable_irq().
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2009-06-02 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 21:52 [PATCH 1/3] ide: remove superfluous SELECT_MASK() call from ide_driveid_update() Bartlomiej Zolnierkiewicz
2009-06-02 15:47 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A254997.1080409@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).