From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 2/2 resend] libata-sff: avoid byte swapping in ata_sff_data_xfer()
Date: Thu, 11 Jun 2009 14:19:51 -0400 [thread overview]
Message-ID: <4A314AC7.40300@pobox.com> (raw)
In-Reply-To: <4A242C81.3080309@ru.mvista.com>
Sergei Shtylyov wrote:
> Hello, I wrote:
>
>>> Handling of the trailing byte in ata_sff_data_xfer() is suboptimal
>>> bacause:
>
>>> - it always initializes the padding buffer to 0 which is not really
>>> needed in
>>> both the read and write cases;
>
>>> - it has to use memcpy() to transfer a single byte from/to the
>>> padding buffer;
>
>>> - it uses io{read|write}16() accessors which swap bytes on the big
>>> endian CPUs
>>> and so have to additionally convert the data from/to the little
>>> endian format
>>> instead of using io{read|write}16_rep() accessors which are not
>>> supposed to
>>> change the byte ordering.
>>>
>>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
>> Jeff, have you forgotten about this one?
>
> PING.
This has been queued to libata-dev.git#upstream, i.e. linux-next queue,
for a long time. Apologies if I forgot the 'applied' reply.
Just sent this upstream, as linux-ide should show.
Jeff
next prev parent reply other threads:[~2009-06-11 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 19:30 [PATCH 2/2 resend] libata-sff: avoid byte swapping in ata_sff_data_xfer() Sergei Shtylyov
2009-02-15 19:48 ` Jeff Garzik
2009-02-15 20:09 ` Sergei Shtylyov
2009-02-17 18:07 ` Sergei Shtylyov
2009-04-07 9:15 ` Sergei Shtylyov
2009-06-01 19:31 ` Sergei Shtylyov
2009-06-11 18:19 ` Jeff Garzik [this message]
2009-06-11 18:28 ` Sergei Shtylyov
2009-04-08 6:33 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A314AC7.40300@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).