From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/3] ata: add ata_id_pio_need_iordy() helper Date: Sun, 14 Jun 2009 00:19:26 +0400 Message-ID: <4A3409CE.9070603@ru.mvista.com> References: <200906131821.07018.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:57070 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752460AbZFMUTa (ORCPT ); Sat, 13 Jun 2009 16:19:30 -0400 In-Reply-To: <200906131821.07018.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, Jeff Garzik Hello. Bartlomiej Zolnierkiewicz wrote: > Cc: Jeff Garzik > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > against Linus' tree > > include/linux/ata.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > Index: b/include/linux/ata.h > =================================================================== > --- a/include/linux/ata.h > +++ b/include/linux/ata.h > @@ -800,6 +800,17 @@ static inline int ata_id_is_ssd(const u1 > return id[ATA_ID_ROT_SPEED] == 0x01; > } > > +static inline int ata_id_pio_need_iordy(const u16 *id, const u8 pio) > +{ > + /* CF spec. r4.1 Table 22 says no IORDY on PIO5 and PIO6. */ > + if (ata_id_is_cfa(id) && pio > 4) > + return 0; > + /* PIO3 and higher it is mandatory. */ > You need some puncuation between "higher" and "it" -- colon or long dash... either that or "for" at the start of the statement. :-) > + if (pio > 2 || ata_id_has_iordy(id)) > + return 1; > + return 0; > +} > + > static inline int ata_drive_40wire(const u16 *dev_id) > { > if (ata_id_is_sata(dev_id)) > MBR, Sergei