From: Jeff Garzik <jgarzik@pobox.com>
To: Evgeni Golov <sargentd@die-welt.net>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] [libata] beautify module parameters
Date: Sun, 21 Jun 2009 23:08:35 -0400 [thread overview]
Message-ID: <4A3EF5B3.1040500@pobox.com> (raw)
In-Reply-To: <1245617000-23868-1-git-send-email-sargentd@die-welt.net>
Evgeni Golov wrote:
> 1. add defaults to description where possible
> 2. add value definition (off=0, on=1) where missing
>
> Signed-off-by: Evgeni Golov <sargentd@die-welt.net>
> ---
> drivers/ata/libata-core.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index ca4d208..da27a3c 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -125,11 +125,11 @@ MODULE_PARM_DESC(force, "Force ATA configurations including cable type, link spe
>
> static int atapi_enabled = 1;
> module_param(atapi_enabled, int, 0444);
> -MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices (0=off, 1=on)");
> +MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices; on by default (0=off, 1=on)");
>
> static int atapi_dmadir = 0;
> module_param(atapi_dmadir, int, 0444);
> -MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support (0=off, 1=on)");
> +MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support; off by default (0=off, 1=on)");
I would prefer a more concise
"Enable ATAPI DMADIR bridge support (0=off [default], 1=on)"
Regards,
Jeff
next prev parent reply other threads:[~2009-06-22 3:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 20:43 [PATCH] [libata] beautify module parameters Evgeni Golov
2009-06-22 3:08 ` Jeff Garzik [this message]
2009-06-22 7:46 ` [PATCH v2] " Evgeni Golov
2009-06-23 5:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3EF5B3.1040500@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=sargentd@die-welt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).