From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
gnoutchd@union.edu, constantine.gavrilov@gmail.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH #upstream] libata: don't set IORDY for reset
Date: Tue, 23 Jun 2009 01:57:32 -0400 [thread overview]
Message-ID: <4A406ECC.9090803@garzik.org> (raw)
In-Reply-To: <4A30663D.9050008@kernel.org>
Tejun Heo wrote:
> Before issuing reset, libata configures xfermode to PIO0 which makes
> some drivers turn on IORDY which may cause the controller to lock up
> if the port is not occupied. IORDY isn't necessary at this point
> anyway. Make ata_pio_need_iordy() return zero if it's being called
> for reset.
>
> This fixes bko#11703. Reported and tracked down by Daniel Gnoutcheff
> and Constantine Gavrilov.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Daniel Gnoutcheff <gnoutchd@union.edu>
> Cc: Constantine Gavrilov <constantine.gavrilov@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> ---
> drivers/ata/libata-core.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
applied
prev parent reply other threads:[~2009-06-23 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 2:04 [PATCH #upstream] libata: don't set IORDY for reset Tejun Heo
2009-06-11 9:15 ` Alan Cox
2009-06-23 5:57 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A406ECC.9090803@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=constantine.gavrilov@gmail.com \
--cc=gnoutchd@union.edu \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).