Re: [PATCH] pata_rdc: driver for RDC ATA devices

Re: [PATCH] pata_rdc: driver for RDC ATA devices

[Jeff Garzik]

Alan Cox wrote:
> Try this version instead - forgot to refresh the patch before sending
> 
> From: Alan Cox <alan@linux.intel.com>
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  drivers/ata/Kconfig    |   10 +
>  drivers/ata/Makefile   |    1 
>  drivers/ata/pata_rdc.c |  400 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 411 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/ata/pata_rdc.c

Requesting that linux-ide be CC'd in the future, for this driver...

Seems fine and fairly straightforward to me.  My lone comment -- go 
through and replace magic numbers with named constants, for e.g. the PCI 
config registers that program timings...

	Jeff

Re: [PATCH] pata_rdc: driver for RDC ATA devices

[Alan Cox]

> Seems fine and fairly straightforward to me.  My lone comment -- go 
> through and replace magic numbers with named constants, for e.g. the PCI 
> config registers that program timings...

Its based on your ata_piix driver. Feel free to update that and I'll pull
names and things across to match.

Re: [PATCH] pata_rdc: driver for RDC ATA devices

[Joe Perches]

On Wed, 2009-06-24 at 23:55 +0100, Alan Cox wrote:
> > Seems fine and fairly straightforward to me.  My lone comment -- go 
> > through and replace magic numbers with named constants, for e.g. the PCI 
> > config registers that program timings...
> 
> Its based on your ata_piix driver. Feel free to update that and I'll pull
> names and things across to match.

I sent a few patches to Jeff privately to do just that.

I'm waiting for Jeff to see if he wants me to post
them publicly or not.

btw:

Jeff, your email address in MAINTAINERS is jgarzik@pobox.com.
Should it be changed to redhat.com or garzik.org or left as is.

$ git log --since=1-year-ago | grep -i "by:.*garzik" | \
	cut -f2- -d":" | sort | uniq -c | sort -rn
    865  Jeff Garzik <jgarzik@redhat.com>
     13  Jeff Garzik <jgarzik@pobox.com>
     13  Jeff Garzik <jeff@garzik.org>

Re: [PATCH] pata_rdc: driver for RDC ATA devices

[Jeff Garzik]

Joe Perches wrote:
> On Wed, 2009-06-24 at 23:55 +0100, Alan Cox wrote:
>>> Seems fine and fairly straightforward to me.  My lone comment -- go 
>>> through and replace magic numbers with named constants, for e.g. the PCI 
>>> config registers that program timings...
>> Its based on your ata_piix driver. Feel free to update that and I'll pull
>> names and things across to match.
> 
> I sent a few patches to Jeff privately to do just that.
> 
> I'm waiting for Jeff to see if he wants me to post
> them publicly or not.

Always post patches publicly...  private mail is easily lost, left 
undiscussed and unarchived, etc.


> Jeff, your email address in MAINTAINERS is jgarzik@pobox.com.
> Should it be changed to redhat.com or garzik.org or left as is.

MAINTAINERS is accurate :)

	Jeff

RE: [PATCH] pata_rdc: driver for RDC ATA devices

[Kevin Huang (黃凱文)]

At first I studied ata_piix driver for our driver, because we need to testing our controller. Then I found it is hard to me.
I needed to clearify the unreadable code of hardware setting and configuration.
So I just modify and clean up original code. And make it simple for beginner or maintainer. I keep original framework and design for future controllers and updates.

This is my first experience of linux driver . Just for share.


-----Original Message-----
>> Seems fine and fairly straightforward to me.  My lone comment -- go 
>> through and replace magic numbers with named constants, for e.g. the PCI 
>> config registers that program timings...

>Its based on your ata_piix driver. Feel free to update that and I'll pull
>names and things across to match.
---------------------------------------------------------------------------------- 
[E-mail Confidentiality Notice]
The information in this e-mail is confidential and may be legally privileged 
otherwise  protected from disclosure. It is intended solely for the 
addressee.  Access to this e-mail by anyone else is unauthorized .If you
are not the intended recipient, any disclosure, copying, distribution or any 
action taken or omitted to be taken in reliance on it, is prohibited and 
maybe unlawful.  Please delete the message and any attachments from 
your computer system; and destroy all hard copies. 

ALL Intellectual Property Rights of RDC Reserved.
----------------------------------------------------------------------------------