* [PATCH] libata: Delegate nonrot flag setting to SCSI
@ 2009-06-25 1:01 Martin K. Petersen
2009-06-25 1:36 ` Jeff Garzik
2009-07-29 1:16 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Martin K. Petersen @ 2009-06-25 1:01 UTC (permalink / raw)
To: Jeff Garzik, jens.axboe, linux-ide
Now that the SCSI disk driver correctly handles non-rotational devices
we can move setting the queue flag to SCSI.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -1119,10 +1119,6 @@ static int ata_scsi_dev_config(struct sc
blk_queue_dma_drain(q, atapi_drain_needed, buf, ATAPI_MAX_DRAIN);
} else {
- if (ata_id_is_ssd(dev->id))
- queue_flag_set_unlocked(QUEUE_FLAG_NONROT,
- sdev->request_queue);
-
/* ATA devices must be sector aligned */
blk_queue_update_dma_alignment(sdev->request_queue,
ATA_SECT_SIZE - 1);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libata: Delegate nonrot flag setting to SCSI
2009-06-25 1:01 [PATCH] libata: Delegate nonrot flag setting to SCSI Martin K. Petersen
@ 2009-06-25 1:36 ` Jeff Garzik
2009-06-25 2:46 ` Martin K. Petersen
2009-07-29 1:16 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2009-06-25 1:36 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: jens.axboe, linux-ide
Martin K. Petersen wrote:
> Now that the SCSI disk driver correctly handles non-rotational devices
> we can move setting the queue flag to SCSI.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>
> ---
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1119,10 +1119,6 @@ static int ata_scsi_dev_config(struct sc
>
> blk_queue_dma_drain(q, atapi_drain_needed, buf, ATAPI_MAX_DRAIN);
> } else {
> - if (ata_id_is_ssd(dev->id))
> - queue_flag_set_unlocked(QUEUE_FLAG_NONROT,
> - sdev->request_queue);
> -
Does the existence of this code cause any problems or regressions today?
It looks correct vis a vis current drivers/scsi/sd.c, but given that the
merge window just closed, I lean towards classifying this as a cleanup
(thus, 2.6.32).
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libata: Delegate nonrot flag setting to SCSI
2009-06-25 1:36 ` Jeff Garzik
@ 2009-06-25 2:46 ` Martin K. Petersen
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2009-06-25 2:46 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Martin K. Petersen, jens.axboe, linux-ide
>>>>> "Jeff" == Jeff Garzik <jeff@garzik.org> writes:
Jeff> Does the existence of this code cause any problems or regressions
Jeff> today?
Nope. We set the flag twice, that's all.
Jeff> It looks correct vis a vis current drivers/scsi/sd.c, but given
Jeff> that the merge window just closed, I lean towards classifying this
Jeff> as a cleanup (thus, 2.6.32).
Up to you. I obviously couldn't submit this patch until the relevant
SCSI bits hit Linus' tree and that didn't happen until yesterday.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: Delegate nonrot flag setting to SCSI
2009-06-25 1:01 [PATCH] libata: Delegate nonrot flag setting to SCSI Martin K. Petersen
2009-06-25 1:36 ` Jeff Garzik
@ 2009-07-29 1:16 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2009-07-29 1:16 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: jens.axboe, linux-ide
Martin K. Petersen wrote:
> Now that the SCSI disk driver correctly handles non-rotational devices
> we can move setting the queue flag to SCSI.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>
> ---
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1119,10 +1119,6 @@ static int ata_scsi_dev_config(struct sc
>
> blk_queue_dma_drain(q, atapi_drain_needed, buf, ATAPI_MAX_DRAIN);
> } else {
> - if (ata_id_is_ssd(dev->id))
> - queue_flag_set_unlocked(QUEUE_FLAG_NONROT,
> - sdev->request_queue);
> -
> /* ATA devices must be sector aligned */
> blk_queue_update_dma_alignment(sdev->request_queue,
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-29 1:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-25 1:01 [PATCH] libata: Delegate nonrot flag setting to SCSI Martin K. Petersen
2009-06-25 1:36 ` Jeff Garzik
2009-06-25 2:46 ` Martin K. Petersen
2009-07-29 1:16 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).