* [PATCH 1/5] drivers/ata: Move a dereference below a NULL test
@ 2009-07-11 7:49 Julia Lawall
2009-07-15 2:43 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2009-07-11 7:49 UTC (permalink / raw)
To: jgarzik, linux-ide, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
If the NULL test is necessary, then the dereference should be moved below
the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/ata/pata_at91.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -u -p a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
--- a/drivers/ata/pata_at91.c
+++ b/drivers/ata/pata_at91.c
@@ -312,11 +312,12 @@ err_ide_ioremap:
static int __devexit pata_at91_remove(struct platform_device *pdev)
{
struct ata_host *host = dev_get_drvdata(&pdev->dev);
- struct at91_ide_info *info = host->private_data;
+ struct at91_ide_info *info;
struct device *dev = &pdev->dev;
if (!host)
return 0;
+ info = host->private_data;
ata_host_detach(host);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/5] drivers/ata: Move a dereference below a NULL test
2009-07-11 7:49 [PATCH 1/5] drivers/ata: Move a dereference below a NULL test Julia Lawall
@ 2009-07-15 2:43 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2009-07-15 2:43 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-ide, linux-kernel, kernel-janitors
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> If the NULL test is necessary, then the dereference should be moved below
> the NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> expression E;
> identifier i,fld;
> statement S;
> @@
>
> - T i = E->fld;
> + T i;
> ... when != E
> when != i
> if (E == NULL) S
> + i = E->fld;
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/ata/pata_at91.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -u -p a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
> @@ -312,11 +312,12 @@ err_ide_ioremap:
> static int __devexit pata_at91_remove(struct platform_device *pdev)
> {
> struct ata_host *host = dev_get_drvdata(&pdev->dev);
> - struct at91_ide_info *info = host->private_data;
> + struct at91_ide_info *info;
> struct device *dev = &pdev->dev;
>
> if (!host)
> return 0;
> + info = host->private_data;
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-15 2:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-11 7:49 [PATCH 1/5] drivers/ata: Move a dereference below a NULL test Julia Lawall
2009-07-15 2:43 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).