Re: [PATCH #NEXT] libata: add command name parsing for error output

[Tejun Heo <tj@kernel.org>]

Robert Hancock wrote:
> This patch improve libata's output for error/notification messages to allow easier
> comprehension and debugging:
> 
> When ATAPI commands issued through the SCSI layer fail, use SCSI functions
> to print the CDB in human-readable form instead of just dumping out the CDB
> in hex.
> 
> Print out the name of the failed command (as defined by the ATA specification)
> in error handling output along with the raw register contents.
> 
> When reporting status of ACPI taskfile commands executed on resume, also output
> the names of the commands being executed (or not) in readable form.
> 
> Since the extra data for printing command names increases kernel size slightly,
> a config option has been added to allow disabling command name output
> (as well as some of the error register parsing) for those highly sensitive to
> kernel text size.
> 
> Signed-off-by: Robert Hancock <hancockrwd@gmail.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun