From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Robert Hancock <hancockrwd@gmail.com>,
Shaohua Li <shaohua.li@intel.com>,
linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [RFC] add DMA setup FIS auto-activate feature
Date: Fri, 24 Jul 2009 05:52:32 +0900 [thread overview]
Message-ID: <4A68CD90.5000404@kernel.org> (raw)
In-Reply-To: <4A68A7C1.2030302@pobox.com>
Jeff Garzik wrote:
> Robert Hancock wrote:
>> Seems reasonable to me, though we may want to print something out
>> during device identification to indicate that we're using AA (like we
>> do for ATAPI AN).
>
> Agreed -- the user needs some indication, somewhere, that this feature
> is enabled.
Also, the return value from ata_dev_set_feature() needs to be checked.
AC_ERR_DEV can be ignored. Other errors should probably set
inhinit-AA bit and fail the current recovery trial.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-07-23 20:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 3:45 [RFC] add DMA setup FIS auto-activate feature Shaohua Li
2009-07-23 3:50 ` Tejun Heo
2009-07-23 3:59 ` Jeff Garzik
2009-07-23 5:40 ` Shaohua Li
2009-07-23 5:45 ` Tejun Heo
2009-07-23 6:07 ` Jeff Garzik
2009-07-23 6:12 ` Tejun Heo
2009-07-23 6:48 ` Jeff Garzik
2009-07-23 7:25 ` Shaohua Li
2009-07-23 18:07 ` Robert Hancock
2009-07-23 18:11 ` Jeff Garzik
2009-07-23 20:52 ` Tejun Heo [this message]
2009-07-24 9:12 ` Shaohua Li
2009-07-25 0:47 ` Tejun Heo
2009-07-27 1:24 ` Shaohua Li
2009-07-27 1:31 ` Tejun Heo
2009-07-29 1:20 ` Jeff Garzik
2009-07-23 6:18 ` Robert Hancock
2009-07-23 9:55 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A68CD90.5000404@kernel.org \
--to=tj@kernel.org \
--cc=hancockrwd@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).