From: Jeff Garzik <jeff@garzik.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: jens.axboe@oracle.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Delegate nonrot flag setting to SCSI
Date: Tue, 28 Jul 2009 21:16:57 -0400 [thread overview]
Message-ID: <4A6FA309.3060106@garzik.org> (raw)
In-Reply-To: <yq1eit9rurq.fsf@sermon.lab.mkp.net>
Martin K. Petersen wrote:
> Now that the SCSI disk driver correctly handles non-rotational devices
> we can move setting the queue flag to SCSI.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>
> ---
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1119,10 +1119,6 @@ static int ata_scsi_dev_config(struct sc
>
> blk_queue_dma_drain(q, atapi_drain_needed, buf, ATAPI_MAX_DRAIN);
> } else {
> - if (ata_id_is_ssd(dev->id))
> - queue_flag_set_unlocked(QUEUE_FLAG_NONROT,
> - sdev->request_queue);
> -
> /* ATA devices must be sector aligned */
> blk_queue_update_dma_alignment(sdev->request_queue,
applied
prev parent reply other threads:[~2009-07-29 1:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 1:01 [PATCH] libata: Delegate nonrot flag setting to SCSI Martin K. Petersen
2009-06-25 1:36 ` Jeff Garzik
2009-06-25 2:46 ` Martin K. Petersen
2009-07-29 1:16 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6FA309.3060106@garzik.org \
--to=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).