From: Tejun Heo <htejun@gmail.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ATA: fix a problem that ata port print_id is used uninitialized
Date: Thu, 30 Jul 2009 13:33:19 +0900 [thread overview]
Message-ID: <4A71228F.5040701@gmail.com> (raw)
In-Reply-To: <1248916316.2670.160.camel@rzhang-dt>
Zhang Rui wrote:
> fix a problem that ata port print_id is used uninitialized.
>
> port print_id is initialized in ata_host_register, but it's
> used in ata_host_start.
> Now move it to ata_host_start, before it's invoked for the first time.
>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
The idea was to assign print_id after the port is pretty much
guaranteed to be registered successfully but doing it earlier
shouldn't harm anything really. So,
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
prev parent reply other threads:[~2009-07-30 4:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 1:11 [PATCH] ATA: fix a problem that ata port print_id is used uninitialized Zhang Rui
2009-07-30 4:33 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A71228F.5040701@gmail.com \
--to=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).