From: Tejun Heo <tj@kernel.org>
To: Julia Lawall <julia@diku.dk>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
geomatsi@gmail.com
Subject: Re: [PATCH 9/10] drivers/ata: introduce missing kfree
Date: Tue, 04 Aug 2009 13:49:16 +0900 [thread overview]
Message-ID: <4A77BDCC.1070502@kernel.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0908011055050.23408@ask.diku.dk>
Julia Lawall wrote:
...
> ---
> drivers/ata/pata_at91.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 5702aff..46fb883 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
> @@ -261,7 +261,8 @@ static int __devinit pata_at91_probe(struct platform_device *pdev)
>
> if (IS_ERR(info->mck)) {
> dev_err(dev, "failed to get access to mck clock\n");
> - return -ENODEV;
> + ret = -ENODEV;
> + goto err_clk_get;
> }
>
> info->cs = board->chipselect;
> @@ -308,6 +309,7 @@ err_alt_ioremap:
>
> err_ide_ioremap:
> clk_put(info->mck);
> +err_clk_get:
> kfree(info);
cc'ing Matyukevich Sergey. Matyukevich, is it possible to use
devm_kzalloc() instead?
Thanks.
--
tejun
next prev parent reply other threads:[~2009-08-04 4:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 8:55 [PATCH 9/10] drivers/ata: introduce missing kfree Julia Lawall
2009-08-04 4:49 ` Tejun Heo [this message]
2009-08-15 7:15 ` Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A77BDCC.1070502@kernel.org \
--to=tj@kernel.org \
--cc=geomatsi@gmail.com \
--cc=jgarzik@pobox.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).