* [PATCH] Soften up the dmesg on SB600 PMP softreset failure recovery
@ 2009-08-05 2:10 Shane Huang
2009-08-05 2:20 ` Tejun Heo
2009-08-12 10:26 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Shane Huang @ 2009-08-05 2:10 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide, tj, pgnet.dev, Huang, Shane
Too strong words led to spurious bug reports: Novell bugzilla #527748,
RedHat bugzilla #468800. This patch is used to soften up the dmesg on
SB600 PMP softreset failure recovery, so as to remove the scariness and
concern from community.
Reported-by: pgnet Dev <pgnet.dev@gmail.com>
Signed-off-by: Shane Huang <shane.huang@amd.com>
Cc: Tejun Heo <tj@kernel.org>
diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
--- a/drivers/ata/ahci.c 2009-07-29 14:38:39.000000000 +0800
+++ b/drivers/ata/ahci.c 2009-08-04 17:24:34.000000000 +0800
@@ -1769,7 +1769,8 @@
irq_sts = readl(port_mmio + PORT_IRQ_STAT);
if (irq_sts & PORT_IRQ_BAD_PMP) {
ata_link_printk(link, KERN_WARNING,
- "failed due to HW bug, retry pmp=0\n");
+ "applying SB600 PMP SRST workaround "
+ "and retrying\n");
rc = ahci_do_softreset(link, class, 0, deadline,
ahci_check_ready);
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Soften up the dmesg on SB600 PMP softreset failure recovery
2009-08-05 2:10 [PATCH] Soften up the dmesg on SB600 PMP softreset failure recovery Shane Huang
@ 2009-08-05 2:20 ` Tejun Heo
2009-08-12 10:26 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2009-08-05 2:20 UTC (permalink / raw)
To: shane.huang; +Cc: jgarzik, linux-ide, pgnet.dev
Shane Huang wrote:
> Too strong words led to spurious bug reports: Novell bugzilla #527748,
> RedHat bugzilla #468800. This patch is used to soften up the dmesg on
> SB600 PMP softreset failure recovery, so as to remove the scariness and
> concern from community.
>
> Reported-by: pgnet Dev <pgnet.dev@gmail.com>
> Signed-off-by: Shane Huang <shane.huang@amd.com>
> Cc: Tejun Heo <tj@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Soften up the dmesg on SB600 PMP softreset failure recovery
2009-08-05 2:10 [PATCH] Soften up the dmesg on SB600 PMP softreset failure recovery Shane Huang
2009-08-05 2:20 ` Tejun Heo
@ 2009-08-12 10:26 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2009-08-12 10:26 UTC (permalink / raw)
To: shane.huang; +Cc: linux-ide, tj, pgnet.dev
Shane Huang wrote:
> Too strong words led to spurious bug reports: Novell bugzilla #527748,
> RedHat bugzilla #468800. This patch is used to soften up the dmesg on
> SB600 PMP softreset failure recovery, so as to remove the scariness and
> concern from community.
>
> Reported-by: pgnet Dev <pgnet.dev@gmail.com>
> Signed-off-by: Shane Huang <shane.huang@amd.com>
> Cc: Tejun Heo <tj@kernel.org>
>
> diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> --- a/drivers/ata/ahci.c 2009-07-29 14:38:39.000000000 +0800
> +++ b/drivers/ata/ahci.c 2009-08-04 17:24:34.000000000 +0800
> @@ -1769,7 +1769,8 @@
> irq_sts = readl(port_mmio + PORT_IRQ_STAT);
> if (irq_sts & PORT_IRQ_BAD_PMP) {
> ata_link_printk(link, KERN_WARNING,
> - "failed due to HW bug, retry pmp=0\n");
> + "applying SB600 PMP SRST workaround "
> + "and retrying\n");
> rc = ahci_do_softreset(link, class, 0, deadline,
> ahci_check_ready);
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-12 10:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-05 2:10 [PATCH] Soften up the dmesg on SB600 PMP softreset failure recovery Shane Huang
2009-08-05 2:20 ` Tejun Heo
2009-08-12 10:26 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).