Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: shane.huang@amd.com
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] kill @force_restart and refine CLO for ahci_kick_engine()
Date: Fri, 07 Aug 2009 16:58:23 +0900	[thread overview]
Message-ID: <4A7BDE9F.6020408@kernel.org> (raw)
In-Reply-To: <1249628752.3413.6.camel@zm-desktop>

Hello, Shane.

Please make the subject look like,

 [PATCH #upstream] ahci: kill @force_restart....

Shane Huang wrote:
> This patch refines ahci_kick_engine() after discussion with Tejun about
> FBS(FIS-based switching) support preparation:
> a. Kill @force_restart and always kick the engine. The only case where
>    @force_restart is zero is when it's called from ahci_p5wdh_hardreset()
>    Actually at that point, BSY is pretty much guaranteed to be set.
> b. If PMP is attached, ignore busy and always do CLO. (AHCI-1.3 9.2)
> 
> Signed-off-by: Shane Huang <shane.huang@amd.com>
> Cc: Tejun Heo <tj@kernel.org>

And put the followings here
---
DIFFSTAT OUTPUT

> 
> diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> --- a/drivers/ata/ahci.c	2009-07-29 14:38:39.000000000 +0800
> +++ b/drivers/ata/ahci.c	2009-08-06 17:36:59.000000000 +0800
> @@ -1578,7 +1578,7 @@

and use -p when generating diffs.  It's usually best to generate diff
from a git tree.

Other than the above peripheral issues,

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

  reply	other threads:[~2009-08-07  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07  7:05 [PATCH] kill @force_restart and refine CLO for ahci_kick_engine() Shane Huang
2009-08-07  7:58 ` Tejun Heo [this message]
2009-08-07  8:04   ` Huang, Shane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7BDE9F.6020408@kernel.org \
    --to=tj@kernel.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=shane.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox