From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: Discard support (was Re: [PATCH] swap: send callback when swap slot is freed) Date: Sat, 15 Aug 2009 09:20:05 -0400 Message-ID: <4A86B605.5060701@rtr.ca> References: <200908122007.43522.ngupta@vflare.org> <87f94c370908131115r680a7523w3cdbc78b9e82373c@mail.gmail.com> <3e8340490908131354q167840fcv124ec56c92bbb830@mail.gmail.com> <4A85E0DC.9040101@rtr.ca> <20090814234539.GE27148@parisc-linux.org> <87f94c370908141730y3ddcb7bbj65d24b612fc0e96d@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org To: Chris Worley Cc: Greg Freemyer , Matthew Wilcox , Bryan Donlan , david@lang.hm, Markus Trippelsdorf , Matthew Wilcox , Hugh Dickins , Nitin Gupta , Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Linux RAID List-Id: linux-ide@vger.kernel.org Chris Worley wrote: .. > So erase blocks are 512 bytes (if I write 512 bytes, an erase block is > now freed)? Not true. .. No, erase blocks are typically 512 KILO-bytes, or 1024 sectors. Logical write blocks are only 512 bytes, but most drives out there now actually use 4096 bytes as the native internal write size. Lots of issues there. The only existing "in the wild" TRIM-capable SSDs today all incur large overheads from TRIM --> they seem to run a garbage-collection and erase cycle for each TRIM command, typically taking 100s of milliseconds regardless of the amount being trimmed. So it makes send to gather small TRIMs into single larger TRIMs. But I think, even better, is to just not bother with the bookkeeping, and instead have the filesystem periodically just issue a TRIM for all free blocks within a block group, cycling through the block groups one by one over time. That's how I'd like it to work on my own machine here. Server/enterprise users very likely want something different. Pluggable architecture, anyone? :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org