From: Tejun Heo <htejun@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jens Axboe <jens.axboe@oracle.com>, Mark Lord <liml@rtr.ca>,
Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: use single threaded work queue
Date: Thu, 20 Aug 2009 21:47:27 +0900 [thread overview]
Message-ID: <4A8D45DF.8010307@gmail.com> (raw)
In-Reply-To: <1250720545.4810.37.camel@pasglop>
Benjamin Herrenschmidt wrote:
> On Wed, 2009-08-19 at 14:23 +0200, Jens Axboe wrote:
>> Well, that's the same thread pool suggestion that Jeff came up with.
>> And
>> I agree, that's a nicer long term solution (it's also how the per-bdi
>> flushing replacement works). The problem with that appears to be that
>> any suggested patchset for thread pools spiral into certain "but what
>> color should it be?!" death.
>>
>> I'll try and work up a simple create_threadpool() implementation, we
>> can
>> literally cut away hundreds of threads with that.
>
> Don't we have one already ? Dave Howells slow_work or such ?
Yes, it addresses different aspect of the concurrency problem. Might
be more suitable for ATA workqueues but definitely more costly to
convert to. Argh...
--
tejun
next prev parent reply other threads:[~2009-08-20 12:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 11:25 [PATCH] libata: use single threaded work queue Jens Axboe
2009-08-19 11:59 ` Jeff Garzik
2009-08-19 12:04 ` Jens Axboe
2009-08-19 12:14 ` Mark Lord
2009-08-19 12:23 ` Jens Axboe
2009-08-19 13:22 ` Jeff Garzik
2009-08-19 13:28 ` Jeff Garzik
2009-08-19 14:11 ` Tejun Heo
2009-08-19 15:21 ` Alan Cox
2009-08-19 15:53 ` Tejun Heo
2009-08-19 16:15 ` Alan Cox
2009-08-19 16:58 ` Tejun Heo
2009-08-19 17:23 ` Alan Cox
2009-08-20 12:46 ` Tejun Heo
2009-08-20 11:39 ` Stefan Richter
2009-08-20 12:11 ` Stefan Richter
2009-08-19 22:22 ` Benjamin Herrenschmidt
2009-08-20 12:47 ` Tejun Heo [this message]
2009-08-20 12:48 ` Tejun Heo
2009-08-20 14:28 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8D45DF.8010307@gmail.com \
--to=htejun@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).