From: Jeff Garzik <jeff@garzik.org>
To: Andrei Martynov <andrei.martynov@web.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: libata: waiting for the drives to settle
Date: Thu, 20 Aug 2009 11:55:47 -0400 [thread overview]
Message-ID: <4A8D7203.50006@garzik.org> (raw)
In-Reply-To: <54773205.20090820114051@web.de>
On 08/20/2009 05:40 AM, Andrei Martynov wrote:
> Hi,
>
> what would be the right place in modern pata driver to implement the
> following old code from function do_probe() in ide-probe.c ?
>
> /*
> * ColdFire platforms boot up so quick that most hard drives
> * have not completed there own self tests. Pause here for
> * a couple of seconds if it looks like there is a drive
> * present...
> */
> if (IN_BYTE(IDE_SELECT_REG) != drive->select.all) {
> printk("IDE: waiting for drives to settle...\n");
> for (rc = 0; (rc< 400); rc++) {
> SELECT_DRIVE(hwif,drive);
> ide_delay_50ms();
> if (IN_BYTE(IDE_SELECT_REG) == drive->select.all)
> break;
> }
> }
>
> It has to be executed once, so placing it into command handler is
> probably not the right solution.
Have you verified this is needed, under libata? We already have several
waits...
Jeff
next prev parent reply other threads:[~2009-08-20 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 9:40 libata: waiting for the drives to settle Andrei Martynov
2009-08-20 15:55 ` Jeff Garzik [this message]
2009-08-21 7:56 ` Re[2]: " Andrei Martynov
2009-08-22 16:13 ` Jeff Garzik
2009-09-02 8:51 ` Re[2]: " Andrei Martynov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8D7203.50006@garzik.org \
--to=jeff@garzik.org \
--cc=andrei.martynov@web.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).