From: Tejun Heo <tj@kernel.org>
To: "Huang, Shane" <Shane.Huang@amd.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH #upstream, v2] ahci: Implement SATA AHCI FIS-based switching support
Date: Wed, 02 Sep 2009 15:49:06 +0900 [thread overview]
Message-ID: <4A9E1562.1050208@kernel.org> (raw)
In-Reply-To: <C8E4BD7D001E44499280E0884BD9DB30FC99B7@sshaexmb1.amd.com>
Huang, Shane wrote:
> Yes, it can leave pp->fbs_enabled out of sync, but just removing the
> check and setting the bit anyway will still lead to the print of this
> message for each SATA port:
> ahci 0000:00:11.0: FBS is disabled.
>
> So I would suggest to keep the check and also add the sync of
> pp->fbs_enabled, which can also save the restart of DMA engine:
Yeap, sure. But in general, it doesn't really matter whether the DMA
engine is started or restarted a few times during intialization. Just
do whatever is safe and looks clean.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-09-02 6:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 4:45 [PATCH #upstream, v2] ahci: Implement SATA AHCI FIS-based switching support Shane Huang
2009-08-31 8:01 ` Tejun Heo
2009-09-01 12:22 ` Huang, Shane
2009-09-01 12:28 ` Tejun Heo
2009-09-01 13:08 ` Huang, Shane
2009-09-01 13:14 ` Tejun Heo
2009-09-02 1:55 ` Huang, Shane
2009-09-02 1:58 ` Tejun Heo
2009-09-02 2:32 ` Huang, Shane
2009-09-02 2:40 ` Tejun Heo
2009-09-02 6:42 ` Huang, Shane
2009-09-02 6:49 ` Tejun Heo [this message]
2009-09-02 6:58 ` Huang, Shane
2009-09-03 4:53 ` Huang, Shane
2009-09-03 6:04 ` Tejun Heo
2009-09-04 2:25 ` Huang, Shane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9E1562.1050208@kernel.org \
--to=tj@kernel.org \
--cc=Shane.Huang@amd.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).