From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Thilo-Alexander Ginkel <thilo@ginkel.com>
Subject: Re: [PATCH #upstream-fixes] libata: unbreak TPM filtering by reorganizing ata_scsi_pass_thru()
Date: Sun, 06 Sep 2009 10:34:23 +0900 [thread overview]
Message-ID: <4AA3119F.6000208@kernel.org> (raw)
In-Reply-To: <4AA30B79.5000308@garzik.org>
Jeff Garzik wrote:
> On 09/03/2009 03:08 AM, Tejun Heo wrote:
>> ata_scsi_pass_thru() was checking for input sanity and disallowed
>> commands while initializaing qc from scmd. TPM filtering was added
>> right after protocol check at which point tf wasn't initialized
>> properly. This means that TPM filtering has never really worked.
>>
>> This patch fixes the bug by reorganizing ata_scsi_pass_thru() such
>> that qc is fully initialized before checking for invalid conditions
>> which is way less error prone.
>>
>> Discovered while Thilo-Alexander Ginkel was trying debug patches for
>> bko#13416.
>>
>> Signed-off-by: Tejun Heo<tj@kernel.org>
>> Cc: Thilo-Alexander Ginkel<thilo@ginkel.com>
>
> If it has never really worked, I would prefer #upstream at this point...
Ummm... Yeap, agreed. Far too deep into -rc cycle.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-09-06 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 7:08 [PATCH #upstream-fixes] libata: unbreak TPM filtering by reorganizing ata_scsi_pass_thru() Tejun Heo
2009-09-06 1:08 ` Jeff Garzik
2009-09-06 1:34 ` Tejun Heo [this message]
2009-09-09 1:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA3119F.6000208@kernel.org \
--to=tj@kernel.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=thilo@ginkel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).