From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH #upstream-fixes] libata: fix off-by-one error in ata_tf_read_block()
Date: Tue, 08 Sep 2009 21:19:33 -0400 [thread overview]
Message-ID: <4AA702A5.9090800@pobox.com> (raw)
In-Reply-To: <4A87F9C1.5090601@gmail.com>
On 08/16/2009 08:21 AM, Tejun Heo wrote:
> ata_tf_read_block() has off-by-one error when converting CHS address
> to LBA. The bug isn't very visible because ata_tf_read_block() is
> used only when generating sense data for a failed RW command and CHS
> addressing isn't used too often these days.
>
> This problem was spotted by Atsushi Nemoto.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: Atsushi Nemoto<anemo@mba.ocn.ne.jp>
> ---
>> Well, I expect fix by you (or other libata hackers) since I think you
>> can write better warning message and changelog than me ;)
>
> In that case, sure. Thanks a lot for the nice spotting. :-)
>
> drivers/ata/libata-core.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
applied
prev parent reply other threads:[~2009-09-09 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-15 13:48 ata_tf_read_block() question Atsushi Nemoto
2009-08-16 2:15 ` Tejun Heo
2009-08-16 9:33 ` Atsushi Nemoto
2009-08-16 12:21 ` [PATCH #upstream-fixes] libata: fix off-by-one error in ata_tf_read_block() Tejun Heo
2009-09-09 1:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA702A5.9090800@pobox.com \
--to=jgarzik@pobox.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).